Migrate D3D10 suite to use the new test registration framework#2662
Open
ahesham-arm wants to merge 5 commits intoKhronosGroup:mainfrom
Open
Migrate D3D10 suite to use the new test registration framework#2662ahesham-arm wants to merge 5 commits intoKhronosGroup:mainfrom
ahesham-arm wants to merge 5 commits intoKhronosGroup:mainfrom
Conversation
Rename `DirectXWrapper` to `DirectX12Wrapper` and only enable it if D3D12 is supported. Update the CMakeLists.txt files to use `target` properties instead of global project ones. No functional change. Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>
Add CMake support for D3D10 and D3D11 in the `directx_wrapper` project.
Including the wrapper subdirectory is now enabled if any of
D3D{10,11,12} are supported.
No code changes, scaffolding only.
Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>
ahesham-arm
changed the title
These two new classes wrap the enumeration and creation of D3D10 and D3D11 adapters and logical devices. Adapters and their related devices are grouped together using simple `DeviceEntry` structs and tracked using a `std::vector` and `ComPtr` to avoid leaking resources.` No functional change, as these wrappers are not yet used. Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>
Replace the custom D3D10 main loop with `runTestHarnesWithCheck` and `REGISTER_TEST`. Add a suite state to initialise D3D once, and discover the adapter/device associated with the OpenCL device under test. Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>
Remove redundant state and helper abstractions. Remove device and window creation logic as it is not used anymore. Remove test stats tracking, use the harness instead. Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>
ahesham-arm
changed the title
Collaborator
Author
|
Hi @joselopeqti I added you as a reviewer just to confirm that this change does not break yout existing DX12 tests in any way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #2181